RFR: 8311301: MethodExitTest may fail with stack buffer overrun

Wed Jul 5 06:42:08 UTC 2023

On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this test-only fix that fixes the size of variables that are used in methods that expect a pointer.
> 
> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method `GetThreadLocalStorage` writes a pointer (64 bits) to the address given by its parameter, which overflows a `long`. The code generated by VS compiler ignores this, but the code generated by clang crashes the test.
> 
> No new tests. MethodExitTest continues to pass on supported platforms, and passes on clang+win with this fix.

The diff to intptr_t was an order of magnitude smaller. But I agree, the code looks better without the casts.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14770#issuecomment-1621120295