Integrated: 8311301: MethodExitTest may fail with stack buffer overrun
Daniel Jeliński
djelinski at openjdk.org
Thu Jul 6 08:57:09 UTC 2023
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Please review this test-only fix that fixes the size of variables that are used in methods that expect a pointer.
>
> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method `GetThreadLocalStorage` writes a pointer (64 bits) to the address given by its parameter, which overflows a `long`. The code generated by VS compiler ignores this, but the code generated by clang crashes the test.
>
> No new tests. MethodExitTest continues to pass on supported platforms, and passes on clang+win with this fix.
This pull request has now been integrated.
Changeset: 3d813ae3
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3d813ae39f4422dd47473608eb8911e2483c6c32
Stats: 20 lines in 1 file changed: 2 ins; 0 del; 18 mod
8311301: MethodExitTest may fail with stack buffer overrun
Reviewed-by: kevinw, dholmes, cjplummer, sspitsyn
-------------
PR: https://git.openjdk.org/jdk/pull/14770
More information about the serviceability-dev
mailing list