RFR: JDK-8310584: GetThreadState reports blocked and runnable for pinned suspended virtual threads [v2]
David Holmes
dholmes at openjdk.org
Tue Jul 18 00:55:14 UTC 2023
On Tue, 18 Jul 2023 00:48:30 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> The change fixes handling of "suspended" bit in VT state.
>> The code looks very strange.
>> java_lang_VirtualThread::RUNNING == 3, so line 803 clears JVMTI_THREAD_STATE_ALIVE(1) and JVMTI_THREAD_STATE_TERMINATED(2)
>> Per log this code came from loom repo with VT integration.
>>
>> Testing: tier1-4, updated GetThreadStateMountedTest.java
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> check that VT is alive before applying suspend/interrupt bits
Seems fine to me, assuming all tests pass.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14878#pullrequestreview-1533917232
More information about the serviceability-dev
mailing list