RFR: JDK-8310584: GetThreadState reports blocked and runnable for pinned suspended virtual threads [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Jul 18 02:47:52 UTC 2023
On Tue, 18 Jul 2023 00:48:30 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> The change fixes handling of "suspended" bit in VT state.
>> The code looks very strange.
>> java_lang_VirtualThread::RUNNING == 3, so line 803 clears JVMTI_THREAD_STATE_ALIVE(1) and JVMTI_THREAD_STATE_TERMINATED(2)
>> Per log this code came from loom repo with VT integration.
>>
>> Testing: tier1-4, updated GetThreadStateMountedTest.java
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> check that VT is alive before applying suspend/interrupt bits
The update looks good.
Need to make sure there are no new failures though.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14878#pullrequestreview-1534021752
More information about the serviceability-dev
mailing list