RFR: 8242152: SA does not include StackMapTables when dumping .class files

[Serguei Spitsyn]

On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu <dqu at openjdk.org> wrote:

> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s `buildreplayjars` command. This bug manifests itself during my diagnosing [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be fixed first.
> 
> I have run jtreg test `tier1-3` of release build on x86 linux finding only one failure in `tier2` caused by [JDK-8309214](https://bugs.openjdk.org/browse/JDK-8309214). `jtreg:test/hotspot/jtreg/serviceability` and `jtreg:test/jdk/sun/tools/` also passed.

This looks good in general.
I've posted one nit about formatting.
What test coverage does this update have?

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java line 639:

> 637:               for (int i = 0; i < stackMapData.length(); i++) {
> 638:                 dos.writeByte(stackMapData.at(i));
> 639:               }

The indent in this file is 8. So, it has to be 8 in fragments: 528-543 and 632-640.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14556#pullrequestreview-1491831245
PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237671930