RFR: 8242152: SA does not include StackMapTables when dumping .class files [v2]

Daohan Qu dqu at openjdk.org
Thu Jun 22 02:37:14 UTC 2023


On Wed, 21 Jun 2023 20:42:04 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some code format issues
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java line 639:
> 
>> 637:               for (int i = 0; i < stackMapData.length(); i++) {
>> 638:                 dos.writeByte(stackMapData.at(i));
>> 639:               }
> 
> The indent in this file is 8. So, it has to be 8 in fragments: 528-543 and 632-640.

Good catch! Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237921778


More information about the serviceability-dev mailing list