RFR: 8302516: Do some cleanup of nsk/share/jdi/EventHandler.java
Leonid Mesnik
lmesnik at openjdk.org
Wed Mar 1 21:15:15 UTC 2023
On Wed, 1 Mar 2023 21:02:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Just as it was before.
>> if (event instanceof ExceptionEvent &&
>> defaultExceptionRequest != null &&
>> defaultExceptionRequest.equals(event.request())) {
>
> I find that much less readable since the 2nd and 3rd lines of the `if` expression are indented the same as the first statement that follows. Previously they had added a blank line to resolve this, but I don't like that either. You shouldn't have a blank line at the start of a compound statement block.
Well, I am not going to insist.
-------------
PR: https://git.openjdk.org/jdk/pull/12568
More information about the serviceability-dev
mailing list