RFR: 8302516: Do some cleanup of nsk/share/jdi/EventHandler.java
Chris Plummer
cjplummer at openjdk.org
Wed Mar 1 21:38:20 UTC 2023
On Wed, 1 Mar 2023 21:12:20 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> I find that much less readable since the 2nd and 3rd lines of the `if` expression are indented the same as the first statement that follows. Previously they had added a blank line to resolve this, but I don't like that either. You shouldn't have a blank line at the start of a compound statement block.
>
> Well, I am not going to insist.
The following doc (and I have no idea how "official" it is since it is 25 years old):
https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
Says to indent the 2nd and 3rd lines by 8 instead of 4. See page 6. Does that seem ok?
-------------
PR: https://git.openjdk.org/jdk/pull/12568
More information about the serviceability-dev
mailing list