RFR: 8302516: Do some cleanup of nsk/share/jdi/EventHandler.java

Leonid Mesnik lmesnik at openjdk.org
Wed Mar 1 21:57:15 UTC 2023


On Wed, 1 Mar 2023 21:35:34 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Well, I am not going to insist.
>
> The following doc (and I have no idea how "official" it is since it is 25 years old):
> 
> https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
> 
> Says to indent the 2nd and 3rd lines by 8 instead of 4.  See page 6. Does that seem ok?

Even if it is not recommended by codestyle, I think the generic rule (for all hotspot) is to keep indentation consistent.  There are a lot of places where 4 spaces are used.  So it is fine to left 4 spaces, but you could update it to 8 if it makes code readable.

-------------

PR: https://git.openjdk.org/jdk/pull/12568


More information about the serviceability-dev mailing list