RFR: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode

Serguei Spitsyn sspitsyn at openjdk.org
Fri Mar 10 03:54:01 UTC 2023


On Thu, 9 Mar 2023 18:55:06 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Please review this small fix. A suspender is a JvmtiVTMSTransitionDisabler monopolist, meaning VTMS_transition_disable_for_all() should not return while there is any active jvmtiVTMSTransitionDisabler. The code though is checking for active "all-disablers" but it's missing the check for active "single disablers".
> I attached a simple reproducer to the bug which I used to test the patch. Not sure if it was worth adding a test so the patch contains just the fix.
> 
> Thanks,
> Patricio

This looks good.
Thank you for catching and taking care about it!
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12956


More information about the serviceability-dev mailing list