RFR: 8292818: replace 96-bit representation for field metadata with variable-sized streams [v4]

Frederic Parain fparain at openjdk.org
Tue Mar 14 13:15:54 UTC 2023


On Mon, 13 Mar 2023 21:53:37 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes includes and style
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java line 48:
> 
>> 46:      * Returns VM internal flags associated with this field
>> 47:      */
>> 48:     int getInternalModifiers();
> 
> We've never exposed the internal modifiers before in public JVMCI API and we should refrain from doing so until there's a good reason to do so. Please remove this method.

Access to internal modifiers is needed in `HotSpotResolvedJavaFieldTest.testEquivalenceForInternalFields()`. I moved the declaration of the method to `HotSpotResolvedJavaField`. Does this change work for you?

-------------

PR: https://git.openjdk.org/jdk/pull/12855


More information about the serviceability-dev mailing list