RFR: 8292818: replace 96-bit representation for field metadata with variable-sized streams [v4]

[Doug Simon]

On Tue, 14 Mar 2023 13:12:31 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java line 48:
>> 
>>> 46:      * Returns VM internal flags associated with this field
>>> 47:      */
>>> 48:     int getInternalModifiers();
>> 
>> We've never exposed the internal modifiers before in public JVMCI API and we should refrain from doing so until there's a good reason to do so. Please remove this method.
>
> Access to internal modifiers is needed in `HotSpotResolvedJavaFieldTest.testEquivalenceForInternalFields()`. I moved the declaration of the method to `HotSpotResolvedJavaField`. Does this change work for you?

Just use reflection to read the internal flags (like this test already does for the `index` field).

I've attached [review.patch](https://github.com/openjdk/jdk/files/10970245/review.patch) with this change and a few other changes I think should be made for better naming (plus one test cleanup).

-------------

PR: https://git.openjdk.org/jdk/pull/12855