RFR: 8303921: serviceability/sa/UniqueVtableTest.java timed out [v2]
David Holmes
dholmes at openjdk.org
Wed Mar 15 02:44:21 UTC 2023
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve NoClassDefFoundError failures; It's known JTReg issue that "@build" actions for part of used shared classes may cause intermittent NoClassDefFoundError in other tests which use the same shared library classpath.
>>
>> Tested: 100 runs on all platforms, no failures
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> feedback
Not sure removing the build directives was the right way to go. As per the jtreg tag guide:
> A test that relies upon library classes should contain appropriate @build directives to ensure that the classes will be compiled. It is strongly recommended that tests do not rely on the use of implicit compilation by the Java compiler.
so the problem is likely caused by missing build directives in the test(s) that fails.
-------------
PR: https://git.openjdk.org/jdk/pull/13030
More information about the serviceability-dev
mailing list