RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v2]

[Adam Sotona]

On Wed, 15 Mar 2023 04:09:04 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Summaries:
>> 1. A few recommendations about updating the constant API is made at https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html and I may update this patch shall the API changes be integrated before
>> 2. One ASM library-specific test, `LambdaAsm` is removed. Others have their code generation infrastructure upgraded from ASM to Classfile API.
>> 3. Most tests are included in tier1, but some are not:
>> In `:jdk_io`: (tier2, part 2)
>> 
>> test/jdk/java/io/Serializable/records/SerialPersistentFieldsTest.java
>> test/jdk/java/io/Serializable/records/ProhibitedMethods.java
>> test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java
>> 
>> In `:jdk_instrument`: (tier 3)
>> 
>> test/jdk/java/lang/instrument/RetransformAgent.java
>> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java
>> test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>> 
>> 
>> @asotona Would you mind reviewing?
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Shorten lines, move from mask() to ACC_ constants, other misc improvements

test/jdk/java/lang/Class/getSimpleName/GetSimpleNameTest.java line 174:

> 172:                 clb.withSuperclass(CD_Object);
> 173:                 clb.withFlags(AccessFlag.PUBLIC, AccessFlag.SUPER);
> 174:                 clb.accept(InnerClassesAttribute.of(

During the API discussions there was slightly more recommended to use `ClasfileBuilder::with` over `ClasfileBuilder::accept`, however it is just a cosmetic difference.

-------------

PR: https://git.openjdk.org/jdk/pull/13009