RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Mar 23 05:54:33 UTC 2023


On Thu, 23 Mar 2023 02:02:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor cleanup in enable_virtual_threads_notify_jvmti()
>
> src/hotspot/share/prims/jvmtiThreadState.hpp line 102:
> 
>> 100: 
>> 101:   static int  VTMS_transition_count()                { return _VTMS_transition_count; }
>> 102:   static void set_VTMS_transition_count(bool val)    { _VTMS_transition_count = val; }
> 
> Although there is a call to `set_VTMS_transition_count()`, I don't see any calls to `VTMS_transition_count()`. Are these really needed?

Thanks.
It was used in an assert that I recently removed as not important. Will remove it as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1145704755


More information about the serviceability-dev mailing list