RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Mar 23 08:35:40 UTC 2023
On Thu, 23 Mar 2023 06:09:42 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Yes, this is from the PR description:
>>> New function JvmtiEnvBase::disable_virtual_threads_notify_jvmti() which is needed for testing.
>>> It is used by the WhiteBox API.
>>
>> Do you think a comment is needed?
>
> I was wondering why we would be testing something that can't ever be triggered by a regular java program.
The function `JvmtiEnvBase::disable_virtual_threads_notify_jvmti()` is needed to test the `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()`. To better test enabling we need to run it multiple times, so disabling is needed as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1145839021
More information about the serviceability-dev
mailing list