RFR: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[]) [v2]
David Holmes
dholmes at openjdk.org
Mon Mar 27 05:12:31 UTC 2023
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> added comments and trim arguments
test/jdk/com/sun/jdi/TestScaffold.java line 469:
> 467: // the first argument not-starting with '-' is treated as a classname
> 468: // the other arguments are split to targetVMArgs targetAppCommandLine correspondingly
> 469: // The example of args for line '@run driver Frames2Test -Xss4M' is '-Xss4M' 'Frames2Targ'.
Is `Frames2Test` a typo there?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13170#discussion_r1148791133
More information about the serviceability-dev
mailing list