RFR: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[]) [v2]

Leonid Mesnik lmesnik at openjdk.org
Mon Mar 27 05:45:31 UTC 2023


On Mon, 27 Mar 2023 05:09:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added comments and trim arguments
>
> test/jdk/com/sun/jdi/TestScaffold.java line 469:
> 
>> 467:         // the first argument not-starting with '-' is treated as a classname
>> 468:         // the other arguments are split to targetVMArgs targetAppCommandLine correspondingly
>> 469:         // The example of args for line '@run driver Frames2Test -Xss4M' is  '-Xss4M' 'Frames2Targ'.
> 
> Is `Frames2Test` a typo there?

Frames2Test is the name of test that uses additional command-line options. It is an example.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13170#discussion_r1148808465


More information about the serviceability-dev mailing list