RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v14]

Martin Doerr mdoerr at openjdk.org
Tue Mar 28 16:36:10 UTC 2023


On Tue, 28 Mar 2023 12:54:41 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   RISCV patch and aarch64 improvement
>
> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 652:
> 
>> 650:     // Scale the index to be the entry index * sizeof(ResolvedInvokeDynamicInfo)
>> 651:     __ sldi(size, size, log2i_exact(sizeof(ResolvedIndyEntry)));
>> 652:     __ add(cache, cache, size);
> 
> @reinrich Is there any specific reason, why you're not calling load_resolved_indy_entry() method here.  On s390x build/changes are stable even with calling that helper method.

It should work if we move the addition of `Array<ResolvedIndyEntry>::base_offset_in_bytes()` into the other caller.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12778#discussion_r1150886679


More information about the serviceability-dev mailing list