RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v14]

[Richard Reingruber]

On Tue, 28 Mar 2023 16:33:09 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 652:
>> 
>>> 650:     // Scale the index to be the entry index * sizeof(ResolvedInvokeDynamicInfo)
>>> 651:     __ sldi(size, size, log2i_exact(sizeof(ResolvedIndyEntry)));
>>> 652:     __ add(cache, cache, size);
>> 
>> @reinrich Is there any specific reason, why you're not calling load_resolved_indy_entry() method here.  On s390x build/changes are stable even with calling that helper method.
>
> It should work if we move the addition of `Array<ResolvedIndyEntry>::base_offset_in_bytes()` into the other caller.

> @reinrich Is there any specific reason, why you're not calling load_resolved_indy_entry() method here. On s390x build/changes are stable even with calling that helper method.

Looks like this was changed on x86_64 after I ported it to ppc. Thanks for making me aware of it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12778#discussion_r1151498444