RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v4]

[Chris Plummer]

On Tue, 2 May 2023 19:57:32 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some test logging improvements.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 63:
> 
>> 61:     // debuggee local var used to find needed non-throwable object
>> 62:     static final String DEBUGGEE_NON_THROWABLE_VAR= "stop002tNonThrowable";
>> 63:     // debuggee local var used to find needed non-throwable object
> 
> This comment is a little bit confusing.
> Should it be one line up or it is intentionally placed before `DEBUGGEE_THROWABLE_VAR`?

It should be "throwable", not "non-throwable"

> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 300:
> 
>> 298:         IntegerValue ival;
>> 299:         do {
>> 300:             ival = (IntegerValue)mainClass.getValue(mainClass.fieldByName("testNumReady"));
> 
> Do we need a sleep at each iteration?

I intentionally did not do one since `getValue()` is fairly slow and involves sending and receiving a JDWP packet. It didn't seem worth the extra noise of a sleep call and the needed exception handling.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1183002318
PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1183006005