RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v4]

Tue May 2 20:37:20 UTC 2023

On Tue, 2 May 2023 20:12:15 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 300:
>> 
>>> 298:         IntegerValue ival;
>>> 299:         do {
>>> 300:             ival = (IntegerValue)mainClass.getValue(mainClass.fieldByName("testNumReady"));
>> 
>> Do we need a sleep at each iteration?
>
> I intentionally did not do one since `getValue()` is fairly slow and involves sending and receiving a JDWP packet. It didn't seem worth the extra noise of a sleep call and the needed exception handling.

Okay, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1183025283