RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v4]
Chris Plummer
cjplummer at openjdk.org
Tue May 2 22:42:24 UTC 2023
On Tue, 2 May 2023 20:37:21 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Test #1 does not involve the debuggee since it is suppose to fail on the JDI side with an exception.
>>
>> I don't think separate methods helps much here. It might even make it a bit harder to understand the flow.
>
>> Test https://github.com/openjdk/jdk/pull/1 does not involve the debuggee
>> since it is suppose to fail on the JDI side with an exception.
>
> Still some comment is needed to explain this.
> Otherwise, it is confusing that the subtests start from the TEST #2. :)
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1183109387
More information about the serviceability-dev
mailing list