RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v4]
Chris Plummer
cjplummer at openjdk.org
Thu May 11 18:25:44 UTC 2023
On Tue, 2 May 2023 19:56:02 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> src/java.se/share/data/jdwp/jdwp.spec line 2024:
>>
>>> 2022: (Error THREAD_NOT_SUSPENDED "The thread is a virtual thread and was not suspended.")
>>> 2023: (Error OPAQUE_FRAME "The thread is a suspended virtual thread and the implementation "
>>> 2024: "was unable to throw an asynchronous exception from this frame.")
>>
>> Should it be aligned with JVMTI and some other places in your fix and say
>> "from the current frame" instead of "from this frame"?
>
> I'm waiting for your JVMTI PR to finish review. I don't want to have to change this more than once.
I've done the update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1191538269
More information about the serviceability-dev
mailing list