RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object [v8]

[Stefan Karlsson]

On Mon, 27 Nov 2023 22:46:15 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> nit: why include 2022 in the copyright header?

Because the test was copied and built upon a test that was created in 2022.

> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 28:
> 
>> 26: #include <pthread.h>
>> 27: #include <stdio.h>
>> 28: #include <unistd.h>
> 
> Should these be in sort order?

Yes

> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 121:
> 
>> 119:   create_monitor_with_dead_object(env);
>> 120: 
>> 121:   // DetachCurrenThread will try to unlock held monitors. This has been a
> 
> nit typo: s/DetachCurrenThread/DetachCurrentThread/

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407317548
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407318161
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407319756