RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object [v8]

[Stefan Karlsson]

On Mon, 27 Nov 2023 22:42:41 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> test/hotspot/jtreg/runtime/Monitor/MonitorWithDeadObjectTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> nit: why include 2022 in the copyright header?

See earlier comment.

> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 149:
> 
>> 147:   if ((*jvm)->DetachCurrentThread(jvm) != JNI_OK) die("DetachCurrentThread");
>> 148: 
>> 149:   return NULL;
> 
> Why is this function return type "void*" when it only returns NULL?

See earlier comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407365519
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407366093