RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v2]
David Holmes
dholmes at openjdk.org
Thu Sep 28 02:14:22 UTC 2023
On Wed, 27 Sep 2023 21:51:38 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> test/lib/jdk/test/lib/hprof/model/Root.java line 145:
>>
>>> 143:
>>> 144: public long getReferrerId() {
>>> 145: return refererId;
>>
>> Spelling: `referrerId`
>
> This is existing field in the class.
> There are a number (45) of misspelled "referer" in the lib, including some public methods (like getReferer() in line 140).
> If you think it makes sense to fix the, I can file a separate CR for this.
Ugghh! Line 140 was not visible by default. It doesn't look good to add a new method called `getReferrerId` when the other usages are `referer`. Lets go for consistency in this PR and fix them all in a separate one. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15869#discussion_r1339431813
More information about the serviceability-dev
mailing list