RFR: JDK-8322042: HeapDumper should perform merge on the current thread instead of VMThread [v2]

Alex Menkov amenkov at openjdk.org
Tue Apr 2 21:40:10 UTC 2024


On Tue, 2 Apr 2024 20:44:13 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comment
>
> src/hotspot/share/services/heapDumper.cpp line 2648:
> 
>> 2646: 
>> 2647:   DumpMerger merger(path, &writer, dumper.dump_seq());
>> 2648:   // perform heapdump file merge operation in the current thread prevents us
> 
> Nit: Better to start with a capital letter.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18571#discussion_r1548639189


More information about the serviceability-dev mailing list