RFR: 8329332: Remove CompiledMethod and CodeBlobLayout classes [v2]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 3 18:55:00 UTC 2024
On Wed, 3 Apr 2024 16:00:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed not_used state of nmethod
>
> Nice!
>
> We've wanted to clean up some interfaces between the CodeCache and the GC code by using nmethod closures instead of CodeBlob closures. This change (and the Sweeper removal) makes it possible to do those cleanups.
>
> I've made a superficial pass over the patch to and left a few comments. Most of those comments are things that would be nice to fix, but could also be left as follow-up RFEs (if they are deemed to be worthy ideas to pursue).
Thank you, @stefank, for great review. I addressed all your comments locally and with run testing in mach5 before pushing it.
Except your suggestion about `find_blob_not_null()` - should be separate RFE.
The same for suggestion "GC interfaces to work directly against nmethod instead of CodeBlob".
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18554#issuecomment-2035354740
More information about the serviceability-dev
mailing list