RFR: 8313332: Simplify lazy jmethodID cache in InstanceKlass [v3]

Coleen Phillimore coleenp at openjdk.org
Thu Apr 4 00:07:34 UTC 2024


On Wed, 3 Apr 2024 23:50:47 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spacing and punctuation.  make log_info into log_debug.
>
> src/hotspot/share/oops/instanceKlass.cpp line 2313:
> 
>> 2311:       size_t size = idnum_allocated_count();
>> 2312:       assert(size > (size_t)idnum, "should already have space");
>> 2313:       jmeths = NEW_C_HEAP_ARRAY(jmethodID, size+1, mtClass);
> 
> nit: spaces around operator `+`

Got them.  The good thing about the smaller function is it's easier to find these.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18549#discussion_r1550659977


More information about the serviceability-dev mailing list