RFR: 8329655: Cleanup KlassObj and klassOop names after the PermGen removal [v2]

Roman Kennke rkennke at openjdk.org
Thu Apr 4 12:18:24 UTC 2024


On Thu, 4 Apr 2024 12:08:23 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1202:
>> 
>>> 1200:   ldrw(scan_temp, Address(recv_klass, Klass::vtable_length_offset()));
>>> 1201: 
>>> 1202:   // %%% Could store the aligned, prescaled offset in the klassoop.
>> 
>> Unrelated, but what's the point of the %%% in all those comments? Might want to remove that, while you're there.
>
> I think it is an old-style TODO. I'm considering if we shouldn't just remove these comments. What do people think about that?

I'm not even sure what they want to say, really. Should be good to remove, and if anybody can make sense of it, record an issue in the bug-tracker?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18618#discussion_r1551557034


More information about the serviceability-dev mailing list