RFR: 8318026: jcmd should provide access to detailed JVM object information [v11]

[Kevin Walls]

On Fri, 29 Mar 2024 04:05:53 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test more pointer types: compiled method and metadata.
>
> test/hotspot/jtreg/serviceability/dcmd/vm/VMInspectTest.java line 117:
> 
>> 115:         output = executor.execute("VM.inspect -1");
>> 116:         output.shouldContain("address not safe");
>> 117: 
> 
> Nit: Just a suggestion to make the test more readable. Now when more test cases have been added you may want to refactor it to call a separate method for each sub-test.
> E.g.: `testBaddAddresses()`, `testMisalignedAddress()`, `testCompiledMethodAddress()`, `testMetadataAddress()`, `testClassAddress()`, `testThreadAddress()`, etc.

Thanks, yes have updated the test and split up the tests.

Also added a retry on the Java object inspection part, as I saw a rare failure where the pointer found in Thread.print is no longer correct when we do the inspect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1551614153