RFR: 8313332: Simplify lazy jmethodID cache in InstanceKlass [v4]
Coleen Phillimore
coleenp at openjdk.org
Thu Apr 4 13:19:14 UTC 2024
On Thu, 4 Apr 2024 00:07:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This change simplifies the code that grows the jmethodID cache in InstanceKlass. Instead of lazily, when there's a rare request for a jmethodID for an obsolete method, the jmethodID cache is grown during the RedefineClasses safepoint. The InstanceKlass's jmethodID cache is lazily allocated when there's a jmethodID allocated, so not every InstanceKlass has a cache, but the growth now only happens in a safepoint. This code will become racy with the potential change for deallocating jmethodIDs.
>>
>> Tested with tier1-4, vmTestbase/nsk/jvmti java/lang/instrument tests (in case they're not in tier1-4).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Two more.
I've run through tiers 5-7 with the patch now. Thank you for the reviews Alex, Serguei and Dan.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18549#issuecomment-2037185846
More information about the serviceability-dev
mailing list