RFR: 8329332: Remove CompiledMethod and CodeBlobLayout classes [v3]

Vladimir Kozlov kvn at openjdk.org
Thu Apr 4 17:04:31 UTC 2024


On Thu, 4 Apr 2024 07:54:16 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Address comments
>>  - Merge branch 'master' into 8329332
>>  - Removed not_used state of nmethod
>>  - remove trailing whitespace
>>  - 8329332: Remove CompiledMethod and CodeBlobLayout classes
>
> I took a second pass over the changes. I've given a few suggestions below. None of them should require respinning of tests (except for making sure that this still builds).

Thank you, @stefank , for second round of review. I addressed all your comments.
I also removed `virtual` from `virtual method() override;` as you suggested before since I touched these files again.
I will wait result of new GHA and tier1 in mach5 before integration.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18554#issuecomment-2037731476


More information about the serviceability-dev mailing list