RFR: 8329491: GetThreadListStackTraces function should use JvmtiHandshake [v2]

[Leonid Mesnik]

On Tue, 2 Apr 2024 23:52:33 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were introduced in the JDK 22 to unify/simplify the JVM TI functions supporting implementation of the virtual threads. This enhancement is to refactor the JVM TI function `GetThreadListStackTraces` on the base of `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes.
>> 
>> Testing:
>>  - Ran mach5 tiers 1-6
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: cleanup - removed temporary logging used for debugging

Changes requested by lmesnik (Reviewer).

src/hotspot/share/prims/jvmtiEnvBase.cpp line 2070:

> 2068: void
> 2069: GetSingleStackTraceClosure::do_thread(Thread *target) {
> 2070:   doit();

I think it makes sense to check that the target is the same as _target_jt. So we don't call it with arbitrary threads.
or require parameter to be null if you want.
Same for do_vthread.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18574#pullrequestreview-1987905071
PR Review Comment: https://git.openjdk.org/jdk/pull/18574#discussion_r1556678646