RFR: JDK-8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" [v2]

Alex Menkov amenkov at openjdk.org
Wed Apr 10 17:36:32 UTC 2024


> The test starts listening on dynamic port and calls stopListening with incorrect (cArgs1) and correct (cArgs2) argument maps.
> Incorrect map is created by finding "free" port (`(new ServerSocket(0)).getLocalPort()`)
> The test fails if the same port is selected later when the listening starts.
> To avoid this free port should be picked after listening on dynamic port started.
> 
> Additionally removed unnecessary `exclusiveAccess.dirs=.` test property and incorrect comment in the description.
> The test uses `SocketListen` connectors, the coment is about `SharedMemoryListen` connector.
> 
> Testing: run the test on all Oracle-supported platforms 100 times

Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:

  Update test/hotspot/jtreg/vmTestbase/nsk/jdi/ListeningConnector/stopListening/stoplis001.java
  
  Co-authored-by: Chris Plummer <chris.plummer at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18705/files
  - new: https://git.openjdk.org/jdk/pull/18705/files/3f9bc6b7..3b0d5540

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18705&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18705&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18705.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18705/head:pull/18705

PR: https://git.openjdk.org/jdk/pull/18705


More information about the serviceability-dev mailing list