RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v3]

Patricio Chilano Mateo pchilanomate at openjdk.org
Fri Apr 12 16:37:42 UTC 2024


On Fri, 12 Apr 2024 12:00:55 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes were introduced in the JDK 22 to unify/simplify the JVM TI functions supporting implementation of the virtual threads. This enhancement is to refactor the JVM TI internal functions JvmtiEnvThreadState::reset_current_location on the base of JvmtiHandshake and JvmtiUnitedHandshakeClosure classes.
>> 
>> Testing:
>>  - Ran mach5 tiers 1-6
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: remove unneded check for is_vthread_alive; do not call do_thread from do_vthread

Thanks Serguei, looks good to me.

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18630#pullrequestreview-1997892115


More information about the serviceability-dev mailing list