Integrated: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

Kevin Walls kevinw at openjdk.org
Tue Apr 16 10:24:09 UTC 2024


On Tue, 9 Apr 2024 11:08:31 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test incorrectly fails, although rarely, thinking its "thread 2" has deadlocked.
> A change of sleep will likely fix this, but there are other issues, so cleaning up the test a little.
> 
> Remove the probe for the ManagementFactory class, to check we are on jdk5 or later. 8-)
> 
> When sleeping, sleep 100, not 1ms, we don't need to spin fast and actually race with the other thread.
> 
> We have a 1000 iteration loop, but don't seem to use it.  We only check once then either return (pass), fail, or break (which is also fail).  Use the loop to check for the status change, which is likely what was intended.
> 
> Show the stackframes on all failures.

This pull request has now been integrated.

Changeset: 58911ccc
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/58911ccc2c48b4b5dd2ebc9d2a44dcf3737eca50
Stats:     42 lines in 1 file changed: 9 ins; 21 del; 12 mod

8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

Reviewed-by: cjplummer, lmesnik

-------------

PR: https://git.openjdk.org/jdk/pull/18687


More information about the serviceability-dev mailing list