RFR: 8329433: Reduce nmethod header size [v6]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 17 17:53:08 UTC 2024
On Wed, 17 Apr 2024 17:10:50 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - remove trailing space
>> - Shuffle fields initialization
>
> src/hotspot/share/code/nmethod.hpp line 259:
>
>> 257: int _orig_pc_offset;
>> 258:
>> 259: int _compile_id; // which compilation made this nmethod
>
> NIT: are these fields always needed?
Yes, they are needed for debugging issues. They are important for error reporting, logs and events recording. And they do not take much space: CompLevel and CompilerType are one byte size.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18768#discussion_r1569237659
More information about the serviceability-dev
mailing list