RFR: 8330388: Remove invokedynamic cache index encoding [v2]

Matias Saavedra Silva matsaave at openjdk.org
Thu Apr 18 16:22:31 UTC 2024


On Wed, 17 Apr 2024 22:41:08 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Dean and Gilles comments
>
> src/hotspot/share/ci/ciEnv.cpp line 1513:
> 
>> 1511:     // process the BSM
>> 1512:     int pool_index = indy_info->constant_pool_index();
>> 1513:     BootstrapInfo bootstrap_specifier(cp, pool_index, indy_index);
> 
> Why not just change the incoming parameter name to `index`?

`indy_index` is used frequently even in functions that are only used in the context of invokedynamic. I think it helps with clarity.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18819#discussion_r1571043673


More information about the serviceability-dev mailing list