RFR: 8328741: serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java failed with unexpected owner [v4]
Chris Plummer
cjplummer at openjdk.org
Tue Apr 23 20:50:28 UTC 2024
On Thu, 18 Apr 2024 21:56:09 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> This is the test issue. The `WaitingPT3` thread posted the `MonitorWait` event but has not released the `lockCheck` monitor yet. It has been fixed to wait for each `WaitingTask` thread to really reach the `WAITING` state. The same approach is used for `EnteringTask` threads. It has been fixed to wait for each `EnteringTask` thread to reach the `BLOCKED_ON_MONITOR` state.
>>
>> Testing:
>> - Reran the test `serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java` locally
>> - TBD: submit the mach5 tiers 1-6 as well
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: tweak in wait_for_state func to allow exp_state bit mask
Changes requested by cjplummer (Reviewer).
test/hotspot/jtreg/serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java line 58:
> 56: native static int setTestedMonitor(Object monitor);
> 57: native static void ensureBlockedOnEnter(Thread thread);
> 58: native static void ensureWaitsToBeNotified(Thread thread);
This should be named "Waiting" instead of "Waits".
-------------
PR Review: https://git.openjdk.org/jdk/pull/18778#pullrequestreview-2018273130
PR Review Comment: https://git.openjdk.org/jdk/pull/18778#discussion_r1576875339
More information about the serviceability-dev
mailing list