RFR: 8330852: All callers of JvmtiEnvBase::get_threadOop_and_JavaThread should pass current thread explicitly
Alex Menkov
amenkov at openjdk.org
Sat Apr 27 00:04:05 UTC 2024
On Fri, 26 Apr 2024 23:36:41 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Some cleanup related to JvmtiEnvBase::get_threadOop_and_JavaThread method
>>
>> Testing: tier1-6
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1976:
>
>> 1974: oop thread_obj = nullptr;
>> 1975:
>> 1976: jvmtiError err = JvmtiEnvBase::get_threadOop_and_JavaThread(tlh.list(), target, current, &java_thread, &thread_obj);
>
> I think a good cleanup would be to also replace `current` with `current_thread`, although I'm not sure how common each are. I see 3 `current` references in this webrev.
Looks like in JVMTI `current_thread` is more common (and `current` is usually used in runtime :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18986#discussion_r1581628063
More information about the serviceability-dev
mailing list