RFR: 8337563: NMT: rename MEMFLAGS to MemFlag

Gerard Ziemski gziemski at openjdk.org
Mon Aug 12 19:48:32 UTC 2024


On Thu, 8 Aug 2024 04:47:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
>> 
>> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
>
> If you called it `MemTypeFlag` - which to me still suggests mutually-exclusive values - then you would not need to rename all the variables with "flag" in their name later.

@dholmes-ora @tstuefe @jdksjolen 

Where are we here? I have renamed MEMFLAGS to MemType.

Is this fine, or do you wish to see a different way to handle this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2284784541


More information about the serviceability-dev mailing list