RFR: 8346123: [REDO] NMT should not use ThreadCritical [v3]

[Robert Toyonaga]

On Wed, 18 Dec 2024 04:31:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updates tests and remove old class
>
> src/hotspot/share/runtime/threads.cpp line 530:
> 
>> 528: 
>> 529:   // Once mutexes are ready, we can use NMT locks.
>> 530:   MemTracker::set_done_bootstrap();
> 
> This should be done after the main thread has attached and set the current thread, otherwise if we hit any NMT code that needs the lock it would crash trying to acquire it.

Ok I've moved it until after `initialize_thread_current`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1890393548