RFR: 8346123: [REDO] NMT should not use ThreadCritical [v3]

[Thomas Stuefe]

On Thu, 19 Dec 2024 02:19:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Okay ... still not sure this shouldn't be dynamically determining whether stdout or stderr is the right target.

We should really have a not-blocking variant of `tty` since er use tty for things like debug output when being deep down the stack. In most cases, printing to a small stringStream and then printing the stream content in one go is what I do to get uninterrupted printing. Works well.

@roberttoyonaga pragmatic proposal would be to just remove this debug output, so the whole ASSERT section. I think I added this way back when we had problems investigating Windows reservations writing over each other, but that problem has been fixed and this assert has not been firing for ages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1891348435