RFR: 8346123: [REDO] NMT should not use ThreadCritical [v6]
Coleen Phillimore
coleenp at openjdk.org
Fri Dec 20 15:18:37 UTC 2024
On Thu, 19 Dec 2024 22:50:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert to using NmtVirtualMemoryLocker. Use defaultStream. Add comment for SharedDecoder_lock
>
> src/hotspot/share/nmt/memTracker.hpp line 72:
>
>> 70: _done_bootstrap = true;
>> 71: }
>> 72:
>
> I think I would prefer "bootstrap_done" rather than "done_bootstrap" throughout. But you should get
> opinions from some of the runtime folks like @coleenp and @dholmes-ora .
Yes, I agree, bootstrap_done reads better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894060699
More information about the serviceability-dev
mailing list