RFR: 8346123: [REDO] NMT should not use ThreadCritical [v6]
    Coleen Phillimore 
    coleenp at openjdk.org
       
    Fri Dec 20 15:40:39 UTC 2024
    
    
  
On Fri, 20 Dec 2024 15:16:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/nmt/memTracker.hpp line 72:
>> 
>>> 70:     _done_bootstrap = true;
>>> 71:   }
>>> 72: 
>> 
>> I think I would prefer "bootstrap_done" rather than "done_bootstrap" throughout.  But you should get
>> opinions from some of the runtime folks like @coleenp and @dholmes-ora .
>
> Yes, I agree, bootstrap_done reads better.
There's a few other is_bootstrapping() predicates in the code like Universe::is_bootstrapping.  This might read nicely as is_bootstrapping_done() and the instance is _bootstrapping_done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894069375
    
    
More information about the serviceability-dev
mailing list