RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v13]

[Martin Doerr]

On Wed, 31 Jan 2024 15:06:54 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> src/hotspot/os/aix/os_aix.cpp line 1176:
>> 
>>> 1174:   strncpy(file_path,filename, buffer_length + 1);
>>> 1175:   char* const pointer_to_dot = strrchr(file_path, '.');
>>> 1176:   assert(pointer_to_dot != nullptr, "Attempting to load a shared object without extension? %s", filename);
>> 
>> This should not only be an assertion. I think the check could be used instead of the strcmp below.
>
> I didn't follow that. You mean i need to keep a check if it is null and print it out ?

An assertion is only used for debug builds. Such an error should be handled in product builds as well. I think an attempt to load an invalid library should simply fail. You may add logging if needed.
@tstuefe: Do you agree or have another proposal to handle such errors?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1473772905