RFR: JDK-8317636: Improve heap walking API tests to verify correctness of field indexes [v2]

[Alex Menkov]

On Fri, 2 Feb 2024 06:47:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback
>
> test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp line 512:
> 
>> 510: JNIEXPORT jboolean JNICALL
>> 511: Java_FieldIndicesTest_testFailed(JNIEnv *env, jclass cls) {
>> 512:     return test_failed ? JNI_TRUE : JNI_FALSE;
> 
> The indent for native files has to be 2, not 4. Even though there are still some tests with wrong indents I'd suggest for new files to follow this rule.

Fixed. Going to integrate the change after sanity testing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17580#discussion_r1476865492