RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Feb 8 10:08:03 UTC 2024
On Wed, 7 Feb 2024 22:49:31 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge
>> - review: thread in notify waiter list can't be BLOCKED
>> - 8324677: Specification clarification needed for JVM TI GetObjectMonitorUsage
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage001/objmonusage001.cpp line 95:
>
>> 93:
>> 94: JNIEXPORT void JNICALL
>> 95: Java_nsk_jvmti_GetObjectMonitorUsage_objmonusage001_check(JNIEnv *env,
>
> I would have expected a modification to an objmonusage001.java file to update
> the parameters to that test's `check()` function.
The parameters of the `check()` method are named short. It is why I decided to skip this update.
Now, I decided to rename parameters to keep them consistent with the other test `objmonusage003`.
So, it has been fixed now, thank you for the suggestion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1482714109
More information about the serviceability-dev
mailing list